Skip to content

Fix(FeatureVariable): Resolves variable value type cast issue #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Fix(FeatureVariable): Resolves variable value type cast issue #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14094a1
Fix(FeatureVariable): Resolves variable value type cast issue
rashidsp Apr 5, 2019
60c6b37
Updates tests
rashidsp Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions src/Optimizely/Optimizely.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,10 @@ public function getFeatureVariableValueForType(
}
}

if (!is_null($variableValue)) {
$variableValue = VariableTypeUtils::castStringToType($variableValue, $variableType, $this->_logger);
}

$attributes = $attributes ?: [];
$this->notificationCenter->sendNotifications(
NotificationType::DECISION,
Expand Down Expand Up @@ -719,19 +723,13 @@ public function getFeatureVariableValueForType(
*/
public function getFeatureVariableBoolean($featureFlagKey, $variableKey, $userId, $attributes = null)
{
$variableValue = $this->getFeatureVariableValueForType(
return $this->getFeatureVariableValueForType(
$featureFlagKey,
$variableKey,
$userId,
$attributes,
FeatureVariable::BOOLEAN_TYPE
);

if (!is_null($variableValue)) {
return VariableTypeUtils::castStringToType($variableValue, FeatureVariable::BOOLEAN_TYPE, $this->_logger);
}

return $variableValue;
}

/**
Expand All @@ -746,19 +744,13 @@ public function getFeatureVariableBoolean($featureFlagKey, $variableKey, $userId
*/
public function getFeatureVariableInteger($featureFlagKey, $variableKey, $userId, $attributes = null)
{
$variableValue = $this->getFeatureVariableValueForType(
return $this->getFeatureVariableValueForType(
$featureFlagKey,
$variableKey,
$userId,
$attributes,
FeatureVariable::INTEGER_TYPE
);

if (!is_null($variableValue)) {
return VariableTypeUtils::castStringToType($variableValue, FeatureVariable::INTEGER_TYPE, $this->_logger);
}

return $variableValue;
}

/**
Expand All @@ -773,19 +765,13 @@ public function getFeatureVariableInteger($featureFlagKey, $variableKey, $userId
*/
public function getFeatureVariableDouble($featureFlagKey, $variableKey, $userId, $attributes = null)
{
$variableValue = $this->getFeatureVariableValueForType(
return $this->getFeatureVariableValueForType(
$featureFlagKey,
$variableKey,
$userId,
$attributes,
FeatureVariable::DOUBLE_TYPE
);

if (!is_null($variableValue)) {
return VariableTypeUtils::castStringToType($variableValue, FeatureVariable::DOUBLE_TYPE, $this->_logger);
}

return $variableValue;
}

/**
Expand All @@ -800,15 +786,13 @@ public function getFeatureVariableDouble($featureFlagKey, $variableKey, $userId,
*/
public function getFeatureVariableString($featureFlagKey, $variableKey, $userId, $attributes = null)
{
$variableValue = $this->getFeatureVariableValueForType(
return $this->getFeatureVariableValueForType(
$featureFlagKey,
$variableKey,
$userId,
$attributes,
FeatureVariable::STRING_TYPE
);

return $variableValue;
}

/**
Expand Down
Loading