Skip to content

Release 3.0.1 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2019
Merged

Release 3.0.1 #170

merged 5 commits into from
Apr 19, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

  • Removed CurlEventDispatcher. See CHANGELOG for more details.

@aliabbasrizvi aliabbasrizvi changed the base branch from master to 3.x.x April 19, 2019 19:04
@aliabbasrizvi aliabbasrizvi requested review from dj-mcculloch, ooola and a team April 19, 2019 19:05
dj-mcculloch
dj-mcculloch reviewed Apr 19, 2019
View reviewed changes
Copy link

@dj-mcculloch dj-mcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo then LGTM.

@coveralls
Copy link

coveralls commented Apr 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 98.961% when pulling 3228b82 on ali/prepare_for_rel into 7073e25 on 3.x.x.

@dj-mcculloch @aliabbasrizvi
Update CHANGELOG.md
3228b82 
Co-Authored-By: aliabbasrizvi <aliabbasrizvi@users.noreply.github.com>
mikeproeng37
mikeproeng37 approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi
Copy link
Contributor Author

@mikeng13 failing test is related to fix made in master.

@aliabbasrizvi aliabbasrizvi merged commit 7cbb08d into 3.x.x Apr 19, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/prepare_for_rel branch April 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ooola ooola Awaiting requested review from ooola

2 more reviewers

@dj-mcculloch dj-mcculloch dj-mcculloch left review comments

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliabbasrizvi @coveralls @mikeproeng37 @dj-mcculloch