Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(decisionService): Move ProjectConfig from DecisionService constructor to individual methods #175

Merged
merged 3 commits into from
Jun 27, 2019
Merged

refact(decisionService): Move ProjectConfig from DecisionService constructor to individual methods #175

merged 3 commits into from
Jun 27, 2019

Conversation

mfahadahmed
Copy link
Contributor

Summary

  • Moved ProjectConfig from DecisionService constructor to individual methods

Test plan

  • Updated unit tests.

@mfahadahmed mfahadahmed added the WIP Work in progress label Jun 17, 2019
@coveralls
Copy link

coveralls commented Jun 17, 2019 •
edited

Coverage Status

Coverage increased (+0.02%) to 99.008% when pulling d9c580b on fahad/move-project-config into 0d549da on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 98.996% when pulling 2b23840 on fahad/move-project-config into 6bc0c7b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 98.996% when pulling 2b23840 on fahad/move-project-config into 6bc0c7b on master.

oakbani
oakbani reviewed Jun 18, 2019
View reviewed changes
src/Optimizely/DecisionService/DecisionService.php Outdated
*
* @return Variation Variation which the user is bucketed into.
*/
public function getVariation(Experiment $experiment, $userId, $attributes = null)
public function getVariation($projectConfig, Experiment $experiment, $userId, $attributes = null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please strict type it ProjectConfig to ensure that it's an instance of ProjectConfig. Also do it for all other methods.

@oakbani oakbani self-requested a review June 19, 2019 12:43
oakbani
oakbani approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@oakbani oakbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mfahadahmed mfahadahmed changed the title Move ProjectConfig from DecisionService constructor to individual methods - WIP refact(decisionService): Move ProjectConfig from DecisionService constructor to individual methods Jun 19, 2019
@mfahadahmed mfahadahmed removed the WIP Work in progress label Jun 19, 2019
aliabbasrizvi
aliabbasrizvi approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit 08a7a12 into master Jun 27, 2019
@oakbani oakbani deleted the fahad/move-project-config branch June 28, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@oakbani oakbani oakbani approved these changes

@rashidsp rashidsp Awaiting requested review from rashidsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mfahadahmed @coveralls @aliabbasrizvi @oakbani @mikeproeng37