Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datafile-management): Adds StaticProjectConfigManager and integrated it with Optimizely class. #179

Merged
merged 17 commits into from
Aug 1, 2019
Merged

feat(datafile-management): Adds StaticProjectConfigManager and integrated it with Optimizely class. #179

merged 17 commits into from
Aug 1, 2019

Conversation

mfahadahmed
Copy link
Contributor

Summary

  • Added ProjectConfigManager interface.
  • Added StaticProjectConfigManager class.
  • Integrated StaticProjectConfigManager with Optimizely class.

Test plan

  • Unit tests updated accordingly.

@mfahadahmed mfahadahmed changed the title feat(datafile-management): Adds StaticProjectConfigManager and integrates it with Optimizely class. feat(datafile-management): Adds StaticProjectConfigManager and integrated it with Optimizely class. Jul 1, 2019
@mfahadahmed mfahadahmed requested a review from a team July 1, 2019 14:54
@coveralls
Copy link

coveralls commented Jul 1, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 98.309% when pulling 94ccc52 on fahad/datafile-manager into 8c35714 on master.

@mfahadahmed mfahadahmed mentioned this pull request Jul 4, 2019
Merged
aliabbasrizvi
aliabbasrizvi approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aliabbasrizvi aliabbasrizvi merged commit 1e4c4a5 into master Aug 1, 2019
@aliabbasrizvi aliabbasrizvi deleted the fahad/datafile-manager branch August 1, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfahadahmed @coveralls @aliabbasrizvi @rashidsp