-
Notifications
You must be signed in to change notification settings - Fork 30
chore(release): Preparing for 3.2.0 release #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, I just have a small suggestion
CHANGELOG.md
Outdated
$configManager = new HTTPProjectConfigManager(<<SDK_KEY>>); | ||
$optimizely = new Optimizely(<<DATAFILE>>, null, null, null, false, null, $configManager); | ||
``` | ||
* The `fetch` method allows you to refresh the config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clarify where the fetch
method can be called with a small sample snippet. I can see users getting confused and thinking of calling fetch
on the client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
No description provided.