refact: return decide reasons instead of appending to a reference parameter #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Dec 17, 2020
| } | ||
|
|
||
| $userExperimentId = $this->findBucket($bucketingId, $userId, $group->getId(), $group->getTrafficAllocation()); |
There was a problem hiding this comment.
Did we have a bug before? "reasons" were not passed down? :)
| @@ -599,23 +611,23 @@ public function testGetVariationUserWithSetForcedVariation() | |||
| $optlyObject->activate($experimentKey, $userId, $userAttributes); | |||
|
|
|||
| // confirm normal bucketing occurs before setting the forced variation | |||
| $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | |||
| $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | |||
Comment on lines
605
to
630
| // test valid experiment | ||
| $this->assertTrue($optlyObject->setForcedVariation($experimentKey, $userId, $forcedVariationKey), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | ||
| $this->assertEquals($forcedVariationKey, $forcedVariationKey); | ||
| // // test valid experiment | ||
| // $this->assertTrue($optlyObject->setForcedVariation($experimentKey, $userId, $forcedVariationKey), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| // $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | ||
| // $this->assertEquals($forcedVariationKey, $forcedVariationKey); | ||
|
|
||
| // clear forced variation and confirm that normal bucketing occurs | ||
| $this->assertTrue($optlyObject->setForcedVariation($experimentKey, $userId, null), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | ||
| $this->assertEquals($bucketedVariationKey, $forcedVariationKey); | ||
| // // clear forced variation and confirm that normal bucketing occurs | ||
| // $this->assertTrue($optlyObject->setForcedVariation($experimentKey, $userId, null), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| // $forcedVariationKey = $optlyObject->getVariation($experimentKey, $userId, $userAttributes); | ||
| // $this->assertEquals($bucketedVariationKey, $forcedVariationKey); | ||
|
|
||
| // check that a paused experiment returns null | ||
| $this->assertTrue($optlyObject->setForcedVariation($pausedExperimentKey, $userId, 'variation'), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| $forcedVariationKey = $optlyObject->getVariation($pausedExperimentKey, $userId, $userAttributes); | ||
| $this->assertNull($forcedVariationKey); | ||
| // // check that a paused experiment returns null | ||
| // $this->assertTrue($optlyObject->setForcedVariation($pausedExperimentKey, $userId, 'variation'), sprintf('Set variation to "%s" failed.', $forcedVariationKey)); | ||
| // $forcedVariationKey = $optlyObject->getVariation($pausedExperimentKey, $userId, $userAttributes); | ||
| // $this->assertNull($forcedVariationKey); |
There was a problem hiding this comment.
Why these tests commented out? Intentional?
There was a problem hiding this comment.
Nice catch. Probably was trying to test something and forgot to revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the way we collect logs for decideReasons. Previously, an array was being passed as reference to each method and each method appended it's log in the passed array. Now, each method returns it's logs along with it's response.
Test plan
Issues