Lowered version for json-schema #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aliabbasrizvi Can this be merged/released? Currently having to maintain a fork to keep our project running. |
|
@cleentfaar change merged. I will get it in a release today itself. |
|
@cleentfaar fix available in version 1.0.1. Hope it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #20 (moved to
develbranch)Composer itself (and related packages such as webmozart/json) requires json-schema ^1.6 or ^2.0, making this package impossible to use within a project.
I've added the required versions, and tests still run fine. However I'm assuming this was set to 4.0.0 for a reason?