Skip to content

Conversation

mnoman09
Copy link
Contributor

Summary

  • prepare for release 3.8.0

@coveralls
Copy link

coveralls commented Sep 16, 2021

Coverage Status

Coverage increased (+0.5%) to 97.476% when pulling 8dc22cf on prep_3.8.0 into 930400f on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CHANGELOG

### New Features:
- The new public properties are added to OptimizelyConfig including sdkKey, environmentKey, attributes, audiences, events, experimentRules and deliveryRules in OptimizelyFeature and audiences in OptimizelyExperiment.
[#230](https://github.com/optimizely/php-sdk/pull/230)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to documentation page?
Also add deprecation note (see one added to the release note of swift-sdk).

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit e46fde5 into master Sep 16, 2021
@zashraf1985 zashraf1985 deleted the prep_3.8.0 branch September 16, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants