Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-8963] doc: Full Stack to Feature Experimentation Rename #261

Merged
merged 5 commits into from Mar 10, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Mar 10, 2023

Summary

  • Update instances of Full Stack to Feature Experimentation
  • Reformat README
  • Add packagist badge

Test plan

  • Existing unit tests & FSC e2e tests should pass

Issues

-FSSDK-8963

@coveralls
Copy link

coveralls commented Mar 10, 2023

Coverage Status

Coverage: 97.149% (-0.3%) from 97.437% when pulling b6bdfce on mike/fx-rename into fa9a3bf on master.

README.md Outdated
@@ -1,38 +1,43 @@
# Optimizely PHP SDK
[![Packagist](https://badgen.net/packagist/v/optimizely/optimizely-sdk)](https://packagist.org/packages/optimizely/optimizely-sdk)
[![Build Status](https://travis-ci.org/optimizely/php-sdk.svg?branch=master)](https://travis-ci.org/optimizely/php-sdk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: take same approach as other SDK (Flutter?) and remove build badge until it's not failing?

composer.json Outdated Show resolved Hide resolved
mikechu-optimizely and others added 2 commits March 10, 2023 16:23
Co-authored-by: Russell Loube <118555704+russell-loube-optimizely@users.noreply.github.com>
Copy link
Contributor

@russell-loube-optimizely russell-loube-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job dogg.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit e3e76b7 into master Mar 10, 2023
9 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/fx-rename branch March 10, 2023 22:45
mikechu-optimizely added a commit that referenced this pull request Mar 13, 2023
* [FSSDK-8963] Update README.md

* [FSSDK-8963] Update composer description

* [FSSDK-8963] Update function docs

* Update composer.json

Co-authored-by: Russell Loube <118555704+russell-loube-optimizely@users.noreply.github.com>

* [FSSDK-8963] Move build badge to GitHub Actions result

---------

Co-authored-by: Russell Loube <118555704+russell-loube-optimizely@users.noreply.github.com>
(cherry picked from commit e3e76b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants