Skip to content

[FSSDK-9073] Update to support PHP 8.x #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
May 26, 2023
Merged

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented May 17, 2023

Summary

As a PHP developer, I want to use SDKs that are compatible with versions of PHP in active support so that the versions of PHP I am running receive updates and security patches.

  • Update minimum PHP 8 language features
  • Move Veracode SourceClear into CI out of cron/scheduled task
  • Minimally update dependencies

Test plan

  • Existing unit tests & FSC test should pass when run under a PHP 8.1 & 8.2 environments

Issues

  • FSSDK-9073

@coveralls
Copy link

coveralls commented May 17, 2023

Coverage Status

Coverage: 97.333% (+0.2%) from 97.092% when pulling 9b26123 on mike/php-8-enough into 825acfe on master.

which is no longer actively supported and security support ends 26 Nov 2023
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review May 25, 2023 20:20
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner May 25, 2023 20:20
Copy link
Contributor Author

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer code review completed

Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 1163b51 into master May 26, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/php-8-enough branch May 26, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants