Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9573] Fix: Deprecation warning #279

Merged
merged 12 commits into from
Aug 10, 2023
Merged

[FSSDK-9573] Fix: Deprecation warning #279

merged 12 commits into from
Aug 10, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Aug 8, 2023 •
edited
Loading

Summary

  • Add missing private field to fix deprecation warning
  • Update devcontainer config
  • Small field name refactor for consistency
  • Small amount of CI refactors

Test plan

  • No functional changes.
  • All unit and end-to-end tests should continue to pass.

Issues

@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner August 8, 2023 16:49
@coveralls
Copy link

coveralls commented Aug 8, 2023 •
edited
Loading

Coverage Status

coverage: 97.333%. remained the same when pulling a333c63 on mike/deprecation-warning into 4eea483 on master.

andrewleap-optimizely
andrewleap-optimizely approved these changes Aug 10, 2023
View reviewed changes
Copy link

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikechu-optimizely mikechu-optimizely merged commit 3fd73a2 into master Aug 10, 2023
11 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/deprecation-warning branch August 10, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikechu-optimizely @coveralls @andrewleap-optimizely