Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly define class properties #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicitly define class properties #284

wants to merge 1 commit into from
+6 −1

Conversation

benschoch
Copy link

@benschoch benschoch commented Feb 13, 2024 •
edited by mikechu-optimizely
Loading

Summary

  • Explicitly define class properties to get rid of deprecation warnings

Issues

Issues

FSSDK-10015

@benschoch benschoch requested a review from a team as a code owner February 13, 2024 10:07
@mikechu-optimizely
Copy link
Contributor

Hiya @benschoch,

Thanks for the collaboration and the code update. I'm running this through our Product team for managing priority.

Are you blocked by this code change?

@benschoch
Copy link
Author

Hey, thanks for the quick answer. It isn’t blocking, no. Even though it really spams our logs currently 😉

@mikechu-optimizely
Copy link
Contributor

I've created internal ticket FSSDK-10015.

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

Thanks for the collab.

@benschoch
Copy link
Author

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

✅

@mikechu-optimizely
Copy link
Contributor

Cool. Thanks. I'm holding for Product to prioritize...but honestly (and gratefully), you've done the work. It should be low-hanging completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benschoch benschoch

Labels
acknowledged
Projects
None yet
Milestone
No milestone
2 participants
@benschoch @mikechu-optimizely