Skip to content

Fixed an issue with setting multiple forced variation values #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2017
Merged

Fixed an issue with setting multiple forced variation values #55

merged 2 commits into from
Aug 14, 2017

Conversation

alda-optimizely
Copy link
Contributor

No description provided.

@optibot
Copy link

optibot commented Aug 11, 2017

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Aug 11, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.372% when pulling cc632ee on alda/forcedBucketing into 9f5bb63 on master.

@mikeproeng37
Copy link
Contributor

Build

1 similar comment
@alda-optimizely
Copy link
Contributor Author

Build

mikeproeng37
mikeproeng37 approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kellyroach-optimizely
kellyroach-optimizely approved these changes Aug 14, 2017
View reviewed changes
Copy link

@kellyroach-optimizely kellyroach-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 131 tests passed - 1s 720ms
OK (131 tests, 334 assertions)

@alda-optimizely alda-optimizely merged commit 823ebcb into master Aug 14, 2017
@alda-optimizely alda-optimizely deleted the alda/forcedBucketing branch August 15, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

@caitlinrubin-optimizely caitlinrubin-optimizely Awaiting requested review from caitlinrubin-optimizely

2 more reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@kellyroach-optimizely kellyroach-optimizely kellyroach-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alda-optimizely @optibot @coveralls @mikeproeng37 @kellyroach-optimizely