Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (audience match types): Condition evaluator and Project Config PRs consolidation. #153

Merged
merged 1 commit into from
Dec 18, 2018
Merged

feat (audience match types): Condition evaluator and Project Config PRs consolidation. #153

merged 1 commit into from
Dec 18, 2018

Conversation

msohailhussain
Copy link
Contributor

Summary

Audience evaluation and project config to support typedAudiences. #146 and #147 consolidated PR that should be merged in master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.693% when pulling 8e596c5 on oakbani/audience-match-types into e5ec118 on master.

@msohailhussain msohailhussain changed the title feat (audience match types): Update condition evaluator for new audie… feat (audience match types): Condition evaluator and Project Config PRs consolidation. Dec 18, 2018
aliabbasrizvi
aliabbasrizvi approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in #146 and #147

@aliabbasrizvi aliabbasrizvi merged commit abb6723 into master Dec 18, 2018
@aliabbasrizvi aliabbasrizvi deleted the oakbani/audience-match-types branch December 18, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msohailhussain @coveralls @aliabbasrizvi @oakbani