Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: Decorate input validation in APIs #163

Closed
wants to merge 1 commit into from
Closed

refact: Decorate input validation in APIs #163

wants to merge 1 commit into from

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jan 18, 2019

Summary

This uses the powerof Python Decorators to decorate input validation in APIs and remove redundancy.

Test plan

Existing Unit Tests pass. No need for additional tests.
Compat Suite Tests pass.

Issues

  • OASIS-4026

@oakbani oakbani requested review from msohailhussain and a team January 18, 2019 11:04
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.679% when pulling 16a02d6 on oakbani/decorate-input-validation into a6709f2 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 99.679% when pulling 16a02d6 on oakbani/decorate-input-validation into a6709f2 on master.

@msohailhussain
Copy link
Contributor

@oakbani Am closing this PR. Since it's will add one more function call overhead

@aliabbasrizvi aliabbasrizvi deleted the oakbani/decorate-input-validation branch June 19, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oakbani @coveralls @msohailhussain