Updating schema for experiments outside of group #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
spencerwilson-optimizely
pushed a commit
that referenced
this pull request
Apr 5, 2018
`SimpleLogger` appears to be a singleton, so the (unused) instantiation of it as `optlog` actually shadows the instatiation passed to `optimizely.Optimizely` as the logger. By removing `optlog` we can actually configure the log level for the latter (very useful when debugging integration tests). For simplicitly, allow the user to set "OPTIMIZELY_SDK_LOG_LEVEL" in the environment to override the default. Set to DEBUG by default. ``` testapp_1 | * Running on http://0.0.0.0:3000/ (Press CTRL+C to quit) testapp_1 | DEBUG 2018-03-28 18:15:56,225 /usr/local/lib/python2.7/site-packages/optimizely/decision_service.py:208:User "josh" meets conditions for targeting rule 1. testapp_1 | DEBUG 2018-03-28 18:15:56,226 /usr/local/lib/python2.7/site-packages/optimizely/bucketer.py:85:Assigned bucket 3579.0 to user with bucketing ID "josh". testapp_1 | INFO 2018-03-28 18:15:56,227 /usr/local/lib/python2.7/site-packages/optimizely/bucketer.py:137:User "josh" is in no variation. testapp_1 | DEBUG 2018-03-28 18:15:56,228 /usr/local/lib/python2.7/site-packages/optimizely/decision_service.py:220:User "josh" is not in the traffic group for the targeting else. Checking "Everyone Else" rule now. testapp_1 | DEBUG 2018-03-28 18:15:56,229 /usr/local/lib/python2.7/site-packages/optimizely/bucketer.py:85:Assigned bucket 4973.0 to user with bucketing ID "josh". testapp_1 | INFO 2018-03-28 18:15:56,230 /usr/local/lib/python2.7/site-packages/optimizely/bucketer.py:137:User "josh" is in no variation. testapp_1 | INFO 2018-03-28 18:15:56,231 /usr/local/lib/python2.7/site-packages/optimizely/optimizely.py:413:Feature "feature_flag" is not enabled for user "josh". ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.