Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving forced variation map from ProjectConfig to DecisionService #180

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Moving forced variation map from ProjectConfig to DecisionService #180

merged 1 commit into from
Jun 11, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Summary

Moving forced variation map from ProjectConfig to DecisionService in preparation.

Test plan

Unit tests pass

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 99.781% when pulling 9c21aca on ali/move_forced_var into 51fef17 on master.

mikeproeng37
mikeproeng37 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 3ce6411 into master Jun 11, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/move_forced_var branch June 11, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mjc1283 mjc1283 Awaiting requested review from mjc1283

@mikecdavis mikecdavis Awaiting requested review from mikecdavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliabbasrizvi @coveralls @mikeproeng37