Skip to content

feat: Cache OptimizelyConfig and set Pyyaml version #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2020
Merged

feat: Cache OptimizelyConfig and set Pyyaml version #234

merged 3 commits into from
Jan 21, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Jan 13, 2020 •
edited
Loading

Summary

Optimizely Config cached in Config Manager. OptimizelyConfig should only be created on datafile update. Otherwise, Config Manager should return a cached copy.

Set Pyyaml version to 5.2 since the latest version 5.3 only works with Python 3.5+. And we need to run tests with Python 3.4 on Travis

Test plan

  • Added unit tests

Issues

OASIS-5791

@oakbani oakbani requested a review from a team as a code owner January 13, 2020 13:06
@oakbani oakbani removed their assignment Jan 13, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 97.746% when pulling b944ecf on oakbani/cache-opt-config into 1785902 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 97.746% when pulling b944ecf on oakbani/cache-opt-config into 1785902 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 97.746% when pulling b944ecf on oakbani/cache-opt-config into 1785902 on master.

@coveralls
Copy link

coveralls commented Jan 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 97.746% when pulling d891872 on oakbani/cache-opt-config into 1785902 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 97.746% when pulling b944ecf on oakbani/cache-opt-config into 1785902 on master.

jaeopt
jaeopt requested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One missing test case is to validate OptConfig data updated correctly after datafile changes. Can we add it?

@oakbani
Copy link
Contributor Author

oakbani commented Jan 14, 2020

Looks good. One missing test case is to validate OptConfig data updated correctly after datafile changes. Can we add it?

Added. Please check.

jaeopt
jaeopt approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thomaszurkan-optimizely
thomaszurkan-optimizely reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakbani oakbani closed this Jan 20, 2020
@oakbani oakbani reopened this Jan 20, 2020
@oakbani oakbani changed the title feat: Cache OptimizelyConfig feat: Cache OptimizelyConfig and set Pyyaml version Jan 20, 2020
@oakbani
Copy link
Contributor Author

oakbani commented Jan 20, 2020

@thomaszurkan-optimizely @msohailhussain I have fixed pyyaml version to 5.2 since the latest release only supports Python 2.7 or Python 3.5+. Have also updated the PR description.

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 2ccae39 into master Jan 21, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the oakbani/cache-opt-config branch January 21, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@zashraf1985 zashraf1985 Awaiting requested review from zashraf1985

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

+1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@oakbani oakbani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakbani @coveralls @thomaszurkan-optimizely @jaeopt @msohailhussain