Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove benchmarking tests #253

Merged
merged 2 commits into from
Apr 27, 2020
Merged

test: Remove benchmarking tests #253

merged 2 commits into from
Apr 27, 2020

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Apr 24, 2020

Summary

Benchmarking tests have become outdated. Removing them as discussed.

Test plan

All tests continue to pass.

Issues

  • OASIS-6305

@oakbani oakbani requested a review from a team as a code owner April 24, 2020 14:39
@oakbani oakbani removed their assignment Apr 24, 2020
@coveralls
Copy link

coveralls commented Apr 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.097% when pulling 4c4c704 on oakbani/remove-benchmarking into 1ca4fca on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling 863f497 on oakbani/remove-benchmarking into 167758d on master.

msohailhussain
msohailhussain approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

Shouldn't we also stop them from running? I still see them in the status checks. Are you planning on doing that in a separate PR?

@oakbani
Copy link
Contributor Author

oakbani commented Apr 27, 2020

Shouldn't we also stop them from running? I still see them in the status checks. Are you planning on doing that in a separate PR?

The one in the status is the fullstack-benchmark-suite. This PR removes the benchmarking python unit tests.

@mikeproeng37
Copy link
Contributor

Shouldn't we also stop them from running? I still see them in the status checks. Are you planning on doing that in a separate PR?

The one in the status is the fullstack-benchmark-suite. This PR removes the benchmarking python unit tests.

Yeah my bad. Lgtm

@aliabbasrizvi aliabbasrizvi merged commit ec767b7 into master Apr 27, 2020
@aliabbasrizvi aliabbasrizvi deleted the oakbani/remove-benchmarking branch April 27, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oakbani @coveralls @mikeproeng37 @aliabbasrizvi @msohailhussain