Skip to content

ci: Add Python 3.8 support #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2020
Merged

ci: Add Python 3.8 support #254

merged 4 commits into from
May 14, 2020

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Apr 24, 2020 •
edited by oakbani
Loading

Summary

  • Adds Python 3.8 support
    Trusty (default build dist) does not support Python 3.8, so this had to be handled in a separate stage using Xenial.
  • Python 3.8 requires coverage 5.x while python 2.7 requires coverage 4.0.3. Thus added >= in requirements with coverage dependency.

@coveralls
Copy link

coveralls commented Apr 24, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.097% when pulling d049425 on mnoman/testOn3.8python into ec767b7 on master.

@oakbani oakbani marked this pull request as ready for review May 14, 2020 00:06
@oakbani oakbani requested a review from a team as a code owner May 14, 2020 00:06
@oakbani oakbani requested a review from aliabbasrizvi May 14, 2020 00:07
@mikeproeng37 mikeproeng37 merged commit 61fddb0 into master May 14, 2020
@mikeproeng37 mikeproeng37 deleted the mnoman/testOn3.8python branch May 14, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi Awaiting requested review from aliabbasrizvi

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mnoman09 @coveralls @aliabbasrizvi @mikeproeng37 @optimizely-codereview-bot @oakbani