Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): Preparing for 3.5.0 release #281

Merged
merged 3 commits into from
Jul 8, 2020
Merged

chore(release): Preparing for 3.5.0 release #281

merged 3 commits into from
Jul 8, 2020

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@aliabbasrizvi aliabbasrizvi requested a review from a team as a code owner July 7, 2020 17:21
@aliabbasrizvi aliabbasrizvi removed their assignment Jul 7, 2020
mikeproeng37
mikeproeng37 suggested changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong version in changelog :)

CHANGELOG.md Outdated
@@ -1,5 +1,17 @@
# Optimizely Python SDK Changelog

## 3.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed. Refresh

mikeproeng37
mikeproeng37 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.096% when pulling 4d0a697 on ali/prep_for_release into f9484bd on master.

@aliabbasrizvi aliabbasrizvi removed their assignment Jul 8, 2020
@aliabbasrizvi aliabbasrizvi merged commit 3e0fa0a into master Jul 8, 2020
@aliabbasrizvi aliabbasrizvi deleted the ali/prep_for_release branch July 8, 2020 21:32
aliabbasrizvi added a commit that referenced this pull request Jul 8, 2020
@aliabbasrizvi
chore(release): Preparing for 3.5.0 release (#281)
011fbab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aliabbasrizvi @coveralls @mikeproeng37