Skip to content

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented May 28, 2021

Summary

Test plan

  • tested with FSC

@Mat001 Mat001 requested a review from a team as a code owner May 28, 2021 23:41
@coveralls
Copy link

coveralls commented May 28, 2021

Coverage Status

Coverage remained the same at 95.838% when pulling 1375bbb on mpirnovar/3_8_1release into 4470ca9 on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

## 3.8.1
May 28th, 2021

### New Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this "new features", the tag should be 3.9.0.
If this is "bug fix", then keep 3.8.1

@Mat001 Mat001 requested a review from jaeopt May 29, 2021 00:11
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the PR title to 3.9.0

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mat001 Mat001 merged commit 7607cf4 into master Jun 1, 2021
@Mat001 Mat001 deleted the mpirnovar/3_8_1release branch June 1, 2021 19:07
The-inside-man pushed a commit that referenced this pull request Jun 15, 2021
* chore: prepare for 3.8.1 release

* fix: version 3.9.0

* fix: update date
@msohailhussain msohailhussain changed the title Chore: prepare for 3.8.1 release Chore: prepare for 3.9.0 release Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants