Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_events_map and get_attributes_map #340

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Remove get_events_map and get_attributes_map #340

merged 2 commits into from
Jul 1, 2021

Conversation

The-inside-man
Copy link
Contributor

Summary

  • Remove not used get_events_map and get_attributes_map
  • Remove associated testing for the above

Test plan

  • Compatibility testing

Issues

  • OASIS-7800

@The-inside-man The-inside-man requested a review from a team as a code owner June 29, 2021 14:18
@coveralls
Copy link

coveralls commented Jun 29, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 95.769% when pulling 0ed0b0f on jbrown/oasis-7800 into 7cc2bde on master.

jaeopt
jaeopt approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man merged commit b55582c into master Jul 1, 2021
@The-inside-man The-inside-man deleted the jbrown/oasis-7800 branch July 1, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keppel2 keppel2 keppel2 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@The-inside-man @coveralls @keppel2 @jaeopt