chore(release): Preparing for 3.9.1 release #348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Jul 14, 2021
I was told to do this PR, then create a new release branch from v3.9.0 and cherrypick this commit and the fix commit once ready. FSC has a few failures so need to make some changes first. |
|
Once merged in I will create a new branch off release V3.9.0 commit and cherry pick this and the other fix commit into the new release branch which will be what we release for the Python SDK. |
| @@ -45,12 +45,12 @@ def create_impression_event( | |||
| if not activated_experiment and rule_type is not enums.DecisionSources.ROLLOUT: | |||
| return None | |||
|
|
|||
| variation, experiment_key = None, None | |||
| variation, experiment_id = None, None | |||
There was a problem hiding this comment.
update license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.