Skip to content

Fix Impression Events - Variation lookup by id and Experiment id #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fix Impression Events - Variation lookup by id and Experiment id #350

merged 2 commits into from
Jul 15, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Jul 15, 2021 •
edited
Loading

Summary

  • Update user_event_factory to use experiment_id when getting variation to fix impression events

Test plan

  • FSC Suite

Issues

  • BugFix

@The-inside-man The-inside-man requested a review from a team as a code owner July 15, 2021 17:04
msohailhussain
msohailhussain approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once license header is updated.

@coveralls
Copy link

coveralls commented Jul 15, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 95.646% when pulling 9610564 on jbrown/fix-impression-events into ab89cf4 on master.

jaeopt
jaeopt approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The-inside-man The-inside-man merged commit 4b324d0 into master Jul 15, 2021
@The-inside-man The-inside-man deleted the jbrown/fix-impression-events branch July 15, 2021 17:23
The-inside-man added a commit that referenced this pull request Jul 15, 2021
@The-inside-man
Fix Impression Events - Variation lookup by id and Experiment id (#350)
3b00f98 
* Fix in user_event_factory to use experiment_id to lookup variation for impression events.

* Update License Header to 2021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@The-inside-man @coveralls @msohailhussain @jaeopt