Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notes for OptimizleyConfigV2 #360

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Add deprecation notes for OptimizleyConfigV2 #360

merged 3 commits into from
Sep 16, 2021

Conversation

The-inside-man
Copy link
Contributor

@The-inside-man The-inside-man commented Sep 16, 2021 •
edited
Loading

Summary

  • Deprecate experiments_map for OptimizelyFeature
  • Note added for experiments_map in OptimizelyConfig stating it is for legacy projects only

OptimizelyFeature experiments_map is deprecated, users shall use experiment_rules and delivery_rules.

Test plan

  • FSC

Issues

  • N/A

@The-inside-man The-inside-man requested a review from a team as a code owner September 16, 2021 16:12
@coveralls
Copy link

coveralls commented Sep 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 96.02% when pulling 3f0f9f1 on jbrown/deprecationV2 into de91292 on master.

jaeopt
jaeopt approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the PR note. OptimizelyConfig experiments_map is not deprecated while that for OptimizelyFeature is. It's still valid for legacy projects. Other than that, LGTM

@The-inside-man The-inside-man merged commit 92174e0 into master Sep 16, 2021
@The-inside-man The-inside-man deleted the jbrown/deprecationV2 branch September 16, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@The-inside-man The-inside-man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@The-inside-man @coveralls @jaeopt