feat: odp datafile parsing and audience evaluation #393
Conversation
There was a problem hiding this comment.
Looks great! A few small changes suggested.
More tests for datafile "integrations" processing including invalid format, missing, and empty will be good.
https://github.com/optimizely/swift-sdk/blob/jae/ats/Tests/OptimizelyTests-DataModel/IntegrationTests.swift
| @@ -54,6 +54,7 @@ def __init__( | |||
| self.client = optimizely_client | |||
| self.logger = logger | |||
| self.user_id = user_id | |||
| self.qualified_segments: list[str] = [] | |||
There was a problem hiding this comment.
Let's make this "qualified_segments" publicly get and set under lock-protected.
You can add this support in the other PR (OptimizelyUserContext) later.
There was a problem hiding this comment.
Added leading underscore to indicate a private variable
| evaluator = condition_helper.CustomAttributeConditionEvaluator( | ||
| qualified_condition_list, self.user_context, self.mock_client_logger, | ||
| ) | ||
|
|
||
| self.assertStrictTrue(evaluator.evaluate(0)) | ||
|
|
||
| def test_qualified__returns_false__when_user_is_not_qualified(self, ): | ||
| self.user_context.qualified_segments = ['odp-segment-1'] | ||
| self.user_context._qualified_segments = ['odp-segment-1'] |
There was a problem hiding this comment.
Don't we need support for atomic getter for "qualified_segments"? like "get_user_attributes()"
There was a problem hiding this comment.
My bad, I thought we were going to implement those during a subsequent PR. I've added a getter and setter for qualified segments.
Summary
A new field
integrationsand new audience typeodp.audienceswill be added to the datafile schema for ODP integration.parse the odp values (
publicKeyandhost)accept datafile with and without the
integrationssection or empty section as well.support a new audience with the
odp.audiencesandqualifiedmatch.support any (allowed) combination of audiences, including ODP and other existing audiences.
Test plan
Added/extended tests in: