Cleanup dependencies #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rouge8 for the change ... looking into this change now. |
| sh==1.11 | ||
| six==1.10.0 | ||
| jsonschema>=2.5.1 | ||
| mmh3>=2.3.1 |
There was a problem hiding this comment.
@rouge8 I would like to keep this at 2.3.1. Other 2 are fine.
|
Thanks for the cleanup @rouge8 ... just the one comment. |
|
@aliabbasrizvi fixed |
|
Thanks! Will this make it into a release fairly soon? |
|
@rouge8 yes !! we are planning to do a release later this week. |
|
@rouge8 version |
spencerwilson-optimizely
pushed a commit
that referenced
this pull request
Apr 5, 2018
* not sure about submodule stuff. open this pr just incase * add tests for notification listener parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes some unused requirements and unpins the versions of the other core dependencies to avoid conflicting with code in other applications.
I suspect the remaining dependencies could be made more flexible, but unpinning requests was my main concern.