Feature/event listener #88

thomaszurkan-optimizely · 2017-10-19T19:57:09Z

No description provided.

coveralls · 2017-10-19T20:32:05Z

Coverage decreased (-0.3%) to 95.644% when pulling 170de07 on feature/eventListener into 4cbf7c5 on master.

coveralls · 2017-10-19T20:53:10Z

Coverage decreased (-0.3%) to 95.644% when pulling 61003b3 on feature/eventListener into 4cbf7c5 on master.

coveralls · 2017-10-19T23:39:07Z

Coverage decreased (-0.2%) to 95.733% when pulling 13937fd on feature/eventListener into 4cbf7c5 on master.

coveralls · 2017-10-25T22:33:15Z

Coverage increased (+0.7%) to 96.577% when pulling 56e9275 on feature/eventListener into 4cbf7c5 on master.

mikeproeng37 · 2017-11-14T19:52:19Z

optimizely/helpers/enums.py

+  """ NotificationTypes for the notification_center.NotificationCenter
+      format is NOTIFICATION TYPE: list of parameters to callback.
+  """
+  ACTIVATE = "ACTIVATE:experiment, user_id,attributes, variation, event"


What was the reason for changing this back to ACTIVATE from DECISION? ACTIVATE is more of an Optimizely term and might not make sense to developers of other anaytics products. Instead DECISION is a more industry-standard term.

@thomaszurkan-optimizely I left a comment here in case you miss it

coveralls · 2017-11-14T19:56:55Z

Coverage increased (+0.5%) to 96.419% when pulling caf64a7 on feature/eventListener into 4cbf7c5 on master.

coveralls · 2017-11-14T23:06:01Z

Coverage increased (+0.5%) to 96.422% when pulling 650d04d on feature/eventListener into 4cbf7c5 on master.

mikeproeng37

Ship it

coveralls · 2017-11-15T22:46:28Z

Coverage decreased (-0.5%) to 96.422% when pulling 8d4c3b2 on feature/eventListener into ebb0ad7 on master.

oakbani · 2017-11-16T14:00:31Z

optimizely/optimizely.py

+        if decision.experiment is not None and \
+                decision.experiment.audienceIds is not None and \
+                len(decision.experiment.audienceIds) > 0:
+          audience_id = decision.experiment.audienceIds[0]


@thomaszurkan-optimizely Hi, I have a question here. In the case where the rollout rule/experiment has multiple audience IDs, and the user didn't qualify for the first audience, but for some other audience id in the list. Do we still send the audience at index 0 in send_notifications method?

coveralls · 2017-11-17T19:34:46Z

Coverage decreased (-0.5%) to 96.422% when pulling 3631a0a on feature/eventListener into ebb0ad7 on master.

coveralls · 2017-11-17T20:13:13Z

Coverage decreased (-0.5%) to 96.422% when pulling c8f2f75 on feature/eventListener into ebb0ad7 on master.

coveralls · 2017-11-17T22:44:04Z

Coverage decreased (-0.5%) to 96.422% when pulling a86bc82 on feature/eventListener into ebb0ad7 on master.

coveralls · 2017-11-18T01:54:51Z

Coverage decreased (-0.03%) to 96.869% when pulling 65a180c on feature/eventListener into ebb0ad7 on master.

coveralls · 2017-11-20T22:33:58Z

Coverage decreased (-0.03%) to 96.869% when pulling e10389f on feature/eventListener into ebb0ad7 on master.

coveralls · 2017-11-21T23:17:33Z

Coverage increased (+0.1%) to 97.027% when pulling ea13f7b on feature/eventListener into ebb0ad7 on master.

mikeproeng37

lgtm, please wait for e2e tests to pass

thomaszurkan-optimizely added 8 commits October 17, 2017 20:30

first pass at event listener

a5c8a07

added event listener access methods

71bd483

added two tests

d58f15d

get event listener to actually be called

465e380

tests for add_event_listener and calling

3d3b3e1

tests for add, remove, clear listener

ec38ce9

update listener unit tests

2777e11

finished unit tests for event listeners

483daab

thomaszurkan-optimizely requested review from mikeproeng37, aliabbasrizvi and alda-optimizely October 19, 2017 19:57

thomaszurkan-optimizely added 2 commits October 19, 2017 13:19

reformat python code

8c75cbd

reformat python code

170de07

comply with python 3.4

61003b3

add test for invalid listener

13937fd

thomaszurkan-optimizely added 10 commits October 20, 2017 13:57

a lot of cleanup

967d303

update from ali's comments

4e1f45d

added event to on activate call as well as on track event

0ed8a1d

initial implementation of notification center

fc087e6

update comments

99f4c4b

added logging and exception handling

77c6141

added feature accessed callback.

cec4a24

added feature access callback and tests

7b92e6e

cleanup

d413d0a

cleanup pep8

56e9275

cleanup pep8

c089242

pass back array of audiences (one right now) for feature rollout

3ace3ff

mikeproeng37 reviewed Nov 14, 2017

View reviewed changes

fix pep8 failure

caf64a7

make changes to work with both python 3 and 2

650d04d

mikeproeng37 approved these changes Nov 15, 2017

View reviewed changes

Merge branch 'master' into feature/eventListener

8d4c3b2

oakbani reviewed Nov 16, 2017

View reviewed changes

thomaszurkan-optimizely added 3 commits November 17, 2017 10:47

check parameters of callbacks in non-strongly typed languages

4d000aa

master was merged. pulled in

c36854d

fix pep8 error

3631a0a

use builtin str for python 2 and 3

c8f2f75

thomaszurkan-optimizely added 2 commits November 17, 2017 14:36

add testing of notification listener parameter types

4833c8e

pep8 mistake

a86bc82

thomaszurkan-optimizely added 3 commits November 17, 2017 17:45

get code coverage up

8b3545c

pep8

15042a8

pep8

65a180c

cleanup comments from mike and matt. prepare for merge

e10389f

remove FEATURE_ROLLOUT and FEATURE_EXPERIMENT

ea13f7b

mikeproeng37 approved these changes Nov 21, 2017

View reviewed changes

thomaszurkan-optimizely merged commit c98a162 into master Nov 21, 2017

aliabbasrizvi deleted the feature/eventListener branch December 11, 2017 19:05

Feature/event listener #88

Feature/event listener #88

Uh oh!

Conversation

thomaszurkan-optimizely commented Oct 19, 2017

Uh oh!

coveralls commented Oct 19, 2017

Uh oh!

coveralls commented Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 25, 2017

Uh oh!

mikeproeng37 Nov 14, 2017

Choose a reason for hiding this comment

Uh oh!

mikeproeng37 Nov 14, 2017

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 14, 2017

Uh oh!

coveralls commented Nov 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikeproeng37 left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oakbani Nov 16, 2017

Choose a reason for hiding this comment

Uh oh!

coveralls commented Nov 17, 2017

Uh oh!

coveralls commented Nov 17, 2017

Uh oh!

coveralls commented Nov 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Nov 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikeproeng37 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coveralls commented Oct 19, 2017 •

edited

Loading

coveralls commented Oct 19, 2017 •

edited

Loading

coveralls commented Nov 14, 2017 •

edited

Loading

coveralls commented Nov 15, 2017 •

edited

Loading

coveralls commented Nov 17, 2017 •

edited

Loading

coveralls commented Nov 18, 2017 •

edited

Loading

coveralls commented Nov 20, 2017 •

edited

Loading

coveralls commented Nov 21, 2017 •

edited

Loading