Skip to content

Updating CHANGELOG and introducing some more unit tests #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2017
Merged

Updating CHANGELOG and introducing some more unit tests #89

merged 3 commits into from
Oct 20, 2017

Conversation

aliabbasrizvi
Copy link
Contributor

No description provided.

@aliabbasrizvi aliabbasrizvi requested review from mauerbac and a team October 20, 2017 21:46
mauerbac
mauerbac approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@mauerbac mauerbac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Oct 20, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 96.893% when pulling 5676271 on arizvi/some_cleanups into 4cbf7c5 on master.

@aliabbasrizvi aliabbasrizvi merged commit 750a4fb into master Oct 20, 2017
@aliabbasrizvi aliabbasrizvi deleted the arizvi/some_cleanups branch October 20, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mauerbac mauerbac mauerbac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliabbasrizvi @coveralls @mauerbac