Skip to content

chore: prep for release 2.8.0 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2022
Merged

chore: prep for release 2.8.0 #143

merged 4 commits into from
Jan 26, 2022

Conversation

zashraf1985
Copy link
Contributor

No description provided.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a clean up suggested

CHANGELOG.md Outdated
- getForcedDecision
- removeForcedDecision
- removeAllForcedDecisions
- Updated `useDecision` hook to auto-update and reflect changes when forced decisions are set and removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR link is missing for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was part of the same PR. I will still add the link though

CHANGELOG.md Outdated
- removeForcedDecision
- removeAllForcedDecisions
- Updated `useDecision` hook to auto-update and reflect changes when forced decisions are set and removed.
- For details, refer to our documentation pages: [ReactSDKClient](https://docs.developers.optimizely.com/full-stack/v4.0/docs/reactsdkclient) and [useDecision hook](https://docs.developers.optimizely.com/full-stack/v4.0/docs/usedecision-react).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs do not include FD. I believe, contents will be updated with the same doc links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I am holding off merging and releasing at least till we have the page skeletons final. This is expected to be updated a little bit

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit 5e5e459 into master Jan 26, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/prep-2.8.0 branch January 26, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants