-
Notifications
You must be signed in to change notification settings - Fork 37
chore: prep for release 2.8.0 #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a clean up suggested
CHANGELOG.md
Outdated
- getForcedDecision | ||
- removeForcedDecision | ||
- removeAllForcedDecisions | ||
- Updated `useDecision` hook to auto-update and reflect changes when forced decisions are set and removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR link is missing for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was part of the same PR. I will still add the link though
CHANGELOG.md
Outdated
- removeForcedDecision | ||
- removeAllForcedDecisions | ||
- Updated `useDecision` hook to auto-update and reflect changes when forced decisions are set and removed. | ||
- For details, refer to our documentation pages: [ReactSDKClient](https://docs.developers.optimizely.com/full-stack/v4.0/docs/reactsdkclient) and [useDecision hook](https://docs.developers.optimizely.com/full-stack/v4.0/docs/usedecision-react). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs do not include FD. I believe, contents will be updated with the same doc links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I am holding off merging and releasing at least till we have the page skeletons final. This is expected to be updated a little bit
c1a6bda
to
8688677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.