Skip to content

chore: added sprintf in logger #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2022
Merged

chore: added sprintf in logger #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11bed8a
added sprintf function in utils and logging
f3sherry Aug 22, 2022
aed274e
end with new line : fix
f3sherry Aug 22, 2022
ae25b9e
end with newline : fixed
f3sherry Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/logger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,20 @@
*/

import * as optimizely from '@optimizely/optimizely-sdk';
import { sprintf } from './utils';
const logHandler = optimizely.logging.createLogger({ prefix: '[React-SDK]' });

export const logger = {
warn: (msg: string, ...splat: any[]) => {
// @ts-ignore
return logHandler.log(optimizely.enums.LOG_LEVEL.WARNING, msg, ...splat);
return logHandler.log(optimizely.enums.LOG_LEVEL.WARNING, sprintf(msg, ...splat));
},
info: (msg: string, ...splat: any[]) => {
// @ts-ignore
return logHandler.log(optimizely.enums.LOG_LEVEL.INFO, msg, ...splat);
return logHandler.log(optimizely.enums.LOG_LEVEL.INFO, sprintf(msg, ...splat));
},
debug: (msg: string, ...splat: any[]) => {
// @ts-ignore
return logHandler.log(optimizely.enums.LOG_LEVEL.DEBUG, msg, ...splat);
return logHandler.log(optimizely.enums.LOG_LEVEL.DEBUG, sprintf(msg, ...splat));
},
error: (msg: string, ...splat: any[]) => {
// @ts-ignore
return logHandler.log(optimizely.enums.LOG_LEVEL.ERROR, msg, ...splat);
return logHandler.log(optimizely.enums.LOG_LEVEL.ERROR, sprintf(msg, ...splat));
},
};
14 changes: 14 additions & 0 deletions src/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,17 @@ export function createFailedDecision(flagKey: string, message: string, user: Use
};
}

export function sprintf(format: string, ...args: any[]): string {
let i = 0;
return format.replace(/%s/g, () => {
const arg = args[i++];
const type = typeof arg;
if (type === 'function') {
return arg();
} else if (type === 'string') {
return arg;
} else {
return String(arg);
}
});
}