Skip to content

Conversation

rafinutshaw-optimizely
Copy link
Contributor

Summary

  • export fetchQualifiedSegments (asynchronous) method
  • make relevant test plans for fetchQualifiedSegments (asynchronous)

Test plan

  • new fetchQualifiedSegments test are added

Issues

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I helped develop. We should ask someone else to review, like @opti-jnguyen or @zashraf1985

@rafinutshaw-optimizely rafinutshaw-optimizely changed the title [React] [FSSDK-8941] Enable ODP Functionality in React Context [FSSDK-8941] [React] Enable ODP Functionality in React Context May 18, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since we have follow-on PRs waiting and @opti-jnguyen is out of office.

@rafinutshaw-optimizely rafinutshaw-optimizely merged commit 215d3fe into master May 19, 2023
@rafinutshaw-optimizely rafinutshaw-optimizely deleted the mike/fetch-qualified-segments branch May 19, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants