Skip to content

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Aug 15, 2024

Summary

Bug fixes

  • clientReady is true even though internal client promise returns success == false bug fix
  • useDecision hook set the update listener on overy render bug fix
  • setForcedDecision does not reflect the changes in optmizely instance and useDecision hook bug fix

Changed

  • Performance improvements in both hooks and client instance

Test plan

Existing test should pass

Issues

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 🙏

@junaed-optimizely junaed-optimizely merged commit c16ea02 into master Aug 15, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/prep-3.2.1 branch August 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants