Skip to content

Allow more acceptable versions of utility-types #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020

Conversation

BenLorantfy
Copy link
Contributor

I'm trying to decrease my dependency install times and this would help de-duplicate my dependency tree. Seems this project only needs Subtract which is present in both 2.x and 3.x

@BenLorantfy
Copy link
Contributor Author

Hey @mikeng13 , any chance you could take a look at this?

@mikeproeng37
Copy link

mikeproeng37 commented May 4, 2020

Thanks for your contribution! Could you please sign our CLA and I can go ahead and get this reviewed in the meantime.

@mikeproeng37 mikeproeng37 requested a review from mjc1283 May 4, 2020 16:31
Copy link
Contributor

@mjc1283 mjc1283 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenLorantfy, this LGTM.

@mjc1283 mjc1283 merged commit cec5081 into optimizely:master May 4, 2020
@BenLorantfy
Copy link
Contributor Author

I signed the CLA btw 👍

@mikeproeng37
Copy link

I signed the CLA btw 👍

Thanks for the quick turn-around! We did check before merging 😄. Again thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants