Skip to content

Refact(README): Adds third party libraries #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 24, 2019
Merged

Refact(README): Adds third party libraries #164

merged 8 commits into from
Jul 24, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Apr 8, 2019

Summary

  • Lists third parties libraries in README.

Issues

  • OASIS-4441

@rashidsp rashidsp requested a review from a team April 8, 2019 13:30
@coveralls
Copy link

coveralls commented Apr 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 99.498% when pulling 7fecd33 on rashid/readme-third-party-libraries into eeea135 on master.

@aliabbasrizvi
Copy link
Contributor

@mikeng13 can you take a look at this?

mikeproeng37
mikeproeng37 approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 49e382a into master Jul 24, 2019
@rashidsp rashidsp deleted the rashid/readme-third-party-libraries branch July 24, 2019 19:07
mikeproeng37 pushed a commit that referenced this pull request Jul 24, 2019
@rashidsp
Refact(README): Adds third party libraries (#164)
ef0e857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @coveralls @aliabbasrizvi @mikeproeng37