Skip to content

Moves forced variations mapping into DecisionService. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

Moves forced variations mapping into DecisionService. #172

merged 1 commit into from
Jun 4, 2019

Conversation

rashidsp
Copy link
Contributor

@rashidsp rashidsp commented Jun 3, 2019 •
edited
Loading

Summary

  • Moved forced variations mapping into DecisionService.
  • Moved forced_variations related tests from project_config.rb to decision_service.rb .
  • Moved input validations and and related tests of set_forced_variation and get_forced_variation to Optimizely.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 99.873% when pulling 814c136 on rashid/move-forced-variations into fccc59f on dfm-complete.

mikeproeng37
mikeproeng37 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit dba2acc into dfm-complete Jun 4, 2019
@rashidsp rashidsp deleted the rashid/move-forced-variations branch June 17, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakbani oakbani Awaiting requested review from oakbani

@msohailhussain msohailhussain Awaiting requested review from msohailhussain

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @mikeproeng37