Skip to content

Refactoring and passing ProjectConfig from Optimizely. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

Refactoring and passing ProjectConfig from Optimizely. #173

merged 1 commit into from
Jun 14, 2019

Conversation

rashidsp
Copy link
Contributor

Summary

  • Moved out ProjectConfig from Bucketer, DecisionService and EventBuilder. Project Config will now only be passed on method calls.

Test plan

Unit tests and compatibility suite tests continue to pass.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.949% when pulling 11506a0 on rashid/move_config into a082d59 on master.

@rashidsp rashidsp requested review from a team and mikeproeng37 June 14, 2019 06:53
mikeproeng37
mikeproeng37 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 0094ed7 into master Jun 14, 2019
@rashidsp rashidsp deleted the rashid/move_config branch June 17, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashidsp @coveralls @mikeproeng37