Skip to content

feat: Added caching for optimizelyConfig object #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2020
Merged

feat: Added caching for optimizelyConfig object #235

merged 4 commits into from
Jan 17, 2020

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Dec 31, 2019 •
edited
Loading

Summary

Updated the OptimizelyConfig implementation to always return cached object. OptimizelyConfig object will only be updated when new ProjectConfig is received.

Test Plan

Added Unit Tests

@zashraf1985 zashraf1985 requested a review from a team as a code owner December 31, 2019 14:24
@coveralls
Copy link

coveralls commented Dec 31, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 99.473% when pulling e92694e on zeeshan/cache-optimizely-config-object into b7b450b on master.

@zashraf1985 zashraf1985 removed their assignment Jan 10, 2020
jaeopt
jaeopt approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985
Copy link
Contributor Author

@mikeng13 @thomaszurkan-optimizely It would be great if one of you can take a look and approve too.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating copy right date in headers.

thomaszurkan-optimizely
thomaszurkan-optimizely suggested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the header on the rb files you touched. copy right should be through 2020. :)

@zashraf1985
Copy link
Contributor Author

Please update the header on the rb files you touched. copy right should be through 2020. :)

Good Catch @thomaszurkan-optimizely . Its done :)

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit c436c00 into master Jan 17, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the zeeshan/cache-optimizely-config-object branch January 17, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@mikeproeng37 mikeproeng37 Awaiting requested review from mikeproeng37

+1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@zashraf1985 zashraf1985

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zashraf1985 @coveralls @thomaszurkan-optimizely @jaeopt @optimizely-codereview-bot