Skip to content

fix(ForcedDecision): remove config-ready check from forced-decision apis #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2021
Merged

fix(ForcedDecision): remove config-ready check from forced-decision apis #290

merged 2 commits into from
Dec 8, 2021

Conversation

ozayr-zaviar
Copy link
Contributor

Summary

  • Remove config-ready check from forced-decision apis

Test plan

  • Unit and FSC tests

@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 99.569% when pulling dcb8997 on uzair/config-check-removed into 1977527 on master.

@msohailhussain msohailhussain requested a review from jaeopt December 8, 2021 19:24
@msohailhussain msohailhussain marked this pull request as ready for review December 8, 2021 19:24
@msohailhussain msohailhussain requested a review from a team as a code owner December 8, 2021 19:24
msohailhussain
msohailhussain approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jaeopt
jaeopt approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit daf4ee1 into master Dec 8, 2021
@msohailhussain msohailhussain deleted the uzair/config-check-removed branch December 8, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ozayr-zaviar ozayr-zaviar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozayr-zaviar @coveralls @msohailhussain @jaeopt