Skip to content

Parse feature flags #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2017
Merged

Parse feature flags #52

merged 3 commits into from
Aug 15, 2017

Conversation

mikeproeng37
Copy link
Contributor

@optimizely/fullstack-devs

Mike Ng added 2 commits August 14, 2017 17:08
Add parsing for feature flags and variables.
ff74e01 
Summary: ^^

Test Plan: Unit

Reviewers: #oasis_team_review

JIRA Issues: OASIS-1647

Differential Revision: https://phabricator.optimizely.com/D17161
Change layerId to rolloutId on the feature flags.
d8edf8a
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.797% when pulling d8edf8a on mng/parse-feature-flags into 2845e14 on master.

@mikeproeng37
Copy link
Contributor Author

Build

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.797% when pulling db27949 on mng/parse-feature-flags into 2845e14 on master.

@mikeproeng37 mikeproeng37 merged commit a2a22e8 into master Aug 15, 2017
@mikeproeng37 mikeproeng37 deleted the mng/parse-feature-flags branch September 8, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangjoshuah wangjoshuah Awaiting requested review from wangjoshuah

1 more reviewer

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeproeng37 @coveralls @aliabbasrizvi