Fix Rollout Bucketer.bucket call & Decision Service logic #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
📝 [OASIS-1962] also addressed in this PR |
|
@wangjoshuah Can you please review |
|
build |
wangjoshuah
suggested changes
Nov 2, 2017
|
|
||
| feature_flag_key = feature_flag['key'] | ||
| variation = get_variation_for_feature_rollout(feature_flag, user_id, attributes) | ||
| if variation | ||
| @config.logger.log( | ||
| Logger::INFO, | ||
| "User '#{user_id}' is in the rollout for feature flag '#{feature_flag_key}'." | ||
| "User '#{user_id}' is bucketed into a rollout for feature flag '#{feature_flag_key}'." |
There was a problem hiding this comment.
describe the actual rule the user was bucketed into by logging the audience name as the rule name.
There was a problem hiding this comment.
You probably meant to have audience name logged inside the get variation for feature rollout and not at this place. I have put it where you have done in the java sdk
…llout 🖊️ Refactored get_audience_conditions_from_id in project config 🖊️ edited affected test cases
|
@wangjoshuah Is there anyone else want to review this code? |
|
@alda-optimizely you've also worked on this SDK before. Do you want to take a look at the PR? |
wangjoshuah
approved these changes
Nov 8, 2017
|
build |
4 similar comments
|
build |
|
build |
|
build |
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Bucketer.bucket call arguments fixed and unit tests cases updated to ensure right number of params are passed
✏️ Revision of logic in Decision Service getVariationForFeatureExperiment
✏️ Refactoring of new Decision Service logic