Skip to content

Sort enabled feature keys #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2018
Merged

Sort enabled feature keys #91

merged 1 commit into from
Mar 12, 2018

Conversation

oakbani
Copy link
Contributor

@oakbani oakbani commented Mar 6, 2018

No description provided.

@optibot
Copy link

optibot commented Mar 6, 2018

Can one of the admins verify this patch?

@mikeproeng37
Copy link
Contributor

build

mikeproeng37
mikeproeng37 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kellyroach-optimizely
Copy link

kellyroach-optimizely commented Mar 12, 2018 •
edited
Loading

E2E TEST PASSED
P.R.#91 branch "oakbani/sort-feature-keys" was tested the new
E2E test for getEnabledFeatures (fullstack-e2e P.R.#118, python-testapp P.R.#12)
and PASSED.

UNIT TESTS
Finished in 1.1 seconds (files took 0.60825 seconds to load)
276 examples, 0 failures
PASSED

Failures in https://jenkins.dz.optimizely.com/job/fullstack-e2e-pipeline/833/console
are due to the new test_get_feature_variable_xxx which are not passing yet, in development,
and independent of this P.R.

kellyroach-optimizely
kellyroach-optimizely approved these changes Mar 12, 2018
View reviewed changes
Copy link

@kellyroach-optimizely kellyroach-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@kellyroach-optimizely kellyroach-optimizely merged commit 086962e into master Mar 12, 2018
@mikeproeng37 mikeproeng37 deleted the oakbani/sort-feature-keys branch June 27, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@kellyroach-optimizely kellyroach-optimizely kellyroach-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakbani @optibot @mikeproeng37 @kellyroach-optimizely