Skip to content

Implements missing validations #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2018
Merged

Implements missing validations #93

merged 1 commit into from
Mar 12, 2018

Conversation

rashidsp
Copy link
Contributor

Updates following optimizely methods to fix empty user_id issue:

🖊️ get_variation
🖊️ track
🖊️ get_feature_variable_for_type

@optibot
Copy link

optibot commented Mar 12, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 99.72% when pulling b9897dc on rashid/optimizely-missing-validations into 2d0cc98 on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 122c69d into master Mar 12, 2018
@clinejj clinejj mentioned this pull request Apr 16, 2018
Closed
@mikeproeng37 mikeproeng37 deleted the rashid/optimizely-missing-validations branch June 27, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashidsp @optibot @coveralls @thomaszurkan-optimizely