cleanup NSError conversion for ObjC #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaeopt
commented
May 6, 2019
jaeopt
commented
- Use implicit conversion of OptimizelyError to NSError
- LocalizedError protocol compliance to automatically add error message into NSError
| @@ -37,7 +37,7 @@ open class DefaultLogger : OPTLogger { | |||
| if level.rawValue > DefaultLogger.logLevel.rawValue { | |||
| return | |||
| } | |||
| let message = "[OPTIMIZELY][" + level.name + "]:" + message | |||
There was a problem hiding this comment.
Should we add timestamp or will nslog automatically add that?
There was a problem hiding this comment.
Timestamp auto added for NSLog and os_log.
We should consider to add os_log for OS10+ (fallback to NSLog for older) later. I'll create a JIRA ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.