Code coverage improvement. #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
reviewed
Jun 26, 2019
| XCTAssert(false) | ||
| case .failure(OptimizelyError.dataFileVersionInvalid): | ||
|
|
||
| if case .failure(OptimizelyError.dataFileVersionInvalid) = result { |
There was a problem hiding this comment.
With this change, we cannot catch error on .success case
jaeopt
reviewed
Jun 26, 2019
| @@ -35,29 +35,30 @@ class ConditionLeafTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testDecodeSample_Invalid() { | |||
|
|
|||
| var tmpError: Error? | |||
There was a problem hiding this comment.
Just curious why this new change looks better to you with less readability. Either way is fine with me.
There was a problem hiding this comment.
It always goes into one of the XCTAssert's, because of which code-cov shows the other two XCTAssert's as uncovered lines. Thats the only reason.
jaeopt
requested changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.