fix: remove accumulated polling when app comes back to foreground #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaeopt
commented
Mar 2, 2020
jaeopt
commented
- When app goes to background, polling stops OK as expected.
- But when app comes back to foreground, the current implementation looks at the timer behind and try to poll multiple times, which is annoying. This fix cleans up this logic, so recover normal periodic polling regardless of delayed timer value.
| @@ -159,19 +159,6 @@ class DefaultDatafileHandler: OPTDatafileHandler { | |||
| } | |||
| } | |||
|
|
|||
| @objc | |||
There was a problem hiding this comment.
why was this removed?
There was a problem hiding this comment.
It is not used anywhere. probably leftover from previous changes.
There was a problem hiding this comment.
leftover from ios 9 support. got it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.