Skip to content

fix: add tests for blanks as invalid #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

fix: add tests for blanks as invalid #351

merged 1 commit into from
Jul 22, 2020

Conversation

thomaszurkan-optimizely
Copy link
Contributor

added check for blanks.

@thomaszurkan-optimizely thomaszurkan-optimizely requested a review from a team as a code owner July 22, 2020 21:06
msohailhussain
msohailhussain approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.748% when pulling 4965dad on addCheckForBlank into 657c48b on master.

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 73ca46a into master Jul 22, 2020
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the addCheckForBlank branch July 22, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@thomaszurkan-optimizely thomaszurkan-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @coveralls @msohailhussain