fix: add check to see that all dot notated areas are numbers. #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +88,7 @@ extension SemanticVersion { | |||
| throw OptimizelyError.attributeFormatInvalid | |||
| } | |||
| var targetedVersionParts = targetPrefix.split(separator: ".") | |||
| guard targetedVersionParts.count == dotCount + 1 else { | |||
| guard targetedVersionParts.count == dotCount + 1 && targetedVersionParts.filter({$0.isNumber}).count == targetedVersionParts.count else { | |||
There was a problem hiding this comment.
am just curious if we need condition written above.
else if !versionParts[idx].isNumber {
There was a problem hiding this comment.
during the evaluation after the suffix has been added it is correct to test if the version is not a number. i thought about adding the if versionParts is not a number and target is a number. But, it should really fail in the split as a invalid format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary