Skip to content

fix(decide): fix a wrong decisionEventDispatched value in decision notification #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

fix(decide): fix a wrong decisionEventDispatched value in decision notification #383

wants to merge 6 commits into from

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jan 28, 2021

No description provided.

@jaeopt jaeopt requested a review from a team as a code owner January 28, 2021 00:29
@jaeopt jaeopt removed their assignment Jan 28, 2021
msohailhussain
msohailhussain approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt closed this Jan 28, 2021
@jaeopt jaeopt reopened this Jan 28, 2021
@coveralls
Copy link

coveralls commented Jan 28, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.698% when pulling 21729ba on jae/event-dispatched into 3b31260 on master.

@jaeopt jaeopt closed this Jan 28, 2021
@jaeopt jaeopt reopened this Jan 28, 2021
@jaeopt jaeopt closed this Jan 29, 2021
@jaeopt jaeopt reopened this Jan 29, 2021
@jaeopt jaeopt closed this Feb 1, 2021
@jaeopt
Copy link
Contributor Author

jaeopt commented Feb 1, 2021

Merged with #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaeopt @coveralls @msohailhussain @optimizely-codereview-bot